nickva commented on code in PR #4813:
URL: https://github.com/apache/couchdb/pull/4813#discussion_r1372262028
##########
src/config/src/config.erl:
##########
@@ -252,7 +251,7 @@ init(IniFiles) ->
ets:new(?MODULE, [named_table, set, protected, {read_concurrency, true}]),
lists:map(
fun(IniFile) ->
- {ok, ParsedIniValues} = parse_ini_file(IniFile),
+ {ok, ParsedIniValues} = parse_ini_file(IniFile, fun delete_keys/1),
Review Comment:
I wonder if with the new behavior the initial load logic can be the same as
the reload. Could we always call parse_init_files with the omit logic being the
default.
I tried to go through a few possible cases in a table:
| | | | | |
| ------------ | - | - | - | - |
| default.ini | X | D | D | X |
| local.ini | X | X | L | L |
| active value | C | D | L | L |
(C - code default, X - delete marker, D, L - default and local values)
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
