jaydoane commented on code in PR #4813:
URL: https://github.com/apache/couchdb/pull/4813#discussion_r1372567049
##########
src/config/test/config_tests.erl:
##########
@@ -441,8 +437,8 @@ should_write_changes(_, _) ->
?assertEqual("5986", config:get("httpd", "port")),
?assertEqual(ok, config:set("httpd", "port", "8080")),
?assertEqual("8080", config:get("httpd", "port")),
- ?assertEqual(ok, config:delete("httpd", "bind_address", "8080")),
- ?assertEqual(undefined, config:get("httpd", "bind_address"))
+ ?assertEqual(ok, config:delete("httpd", "bind_address")),
+ ?assertEqual("127.0.0.1", config:get("httpd", "bind_address"))
Review Comment:
It was `undefined` before because the `config:delete("httpd",
"bind_address")` on the previous line removed it from the `ets` table, but did
not reload the default. With this change, after deletion the default gets
reloaded from disk and inserted into the ets table. In short, It is the crux of
this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
