jaydoane commented on code in PR #4835:
URL: https://github.com/apache/couchdb/pull/4835#discussion_r1390273239
##########
README-DEV.rst:
##########
@@ -272,6 +266,51 @@ to keep those databases around for further investigation::
MANGO_TESTS_KEEP_DBS=please \
make mango-test MANGO_TEST_OPTS='03-operator-test'
+Running Clouseau
+~~~~~~~~~~~~~~~~
+
+When configured with the ``./configure`` script, the ``./dev/run``
+script is capable of launching Clouseau instances alongside the
+CouchDB nodes and hooking them up. This is what the ``mango-test``
+and ``elixir-search`` targets also use to run their respective test
+suites and let Clouseau automatically managed for them.
Review Comment:
Maybe insert a comma after "suites", change "managed" to "manage", and
delete "for".
##########
configure:
##########
@@ -38,6 +39,8 @@ run_erlang() {
COUCHDB_USER="$(whoami 2>/dev/null || echo couchdb)"
SM_VSN=${SM_VSN:-"91"}
+CLOUSEAU_VSN=${CLOUSEAU_VSN:-"2.22.0"}
+CLOUSEAU_DIR="$(pwd)"/clouseau
Review Comment:
I was pondering whether it made sense to stick this into `src` like all the
other (Erlang) deps, but then noticed that `nouveau` was also at the top level,
so guessing that was the precedent you used for deciding where this should go?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
