big-r81 commented on code in PR #4835:
URL: https://github.com/apache/couchdb/pull/4835#discussion_r1396052971
##########
Makefile:
##########
@@ -313,19 +319,24 @@ list-eunit-suites:
build-test:
@test/build/test-configure.sh
+ifeq ($(with_clouseau), 1)
+_WITH_CLOUSEAU="--with-clouseau"
+endif
.PHONY: mango-test
# target: mango-test - Run Mango tests
mango-test: export COUCHDB_TEST_ADMIN_PARTY_OVERRIDE=1
mango-test: devclean all
- @cd src/mango && \
- python3 -m venv .venv && \
- .venv/bin/python3 -m pip install -r requirements.txt
- @cd src/mango && \
- ../../dev/run "$(TEST_OPTS)" \
+ @python3 -m venv src/mango/.venv && \
Review Comment:
Only a small nit. I don't know if we used it consequently, but should we use
the defined env var `PYTHON` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
