jcoglan opened a new pull request, #4887: URL: https://github.com/apache/couchdb/pull/4887
## Overview Weatherreport is hard-coded to assume the search node is at '[email protected]' and that it is running. This results in a useless warning for users that do not have search enabled, and also means that it will fail to connect if Clouseau is running somewhere other than 127.0.0.1. This replaces the hard-coded node name with a config lookup to `[dreyfus] name` and handles the case of it not being set. ## Testing recommendations On `main`, running `weatherreport` against my dev cluster prints this warning about Clouseau not responding, regardless of what `[dreyfus] name` is set to: ``` $ ./weatherreport -c ../../dev/lib/node1/etc ['[email protected]'] [warning] Local search node at '[email protected]' not responding: pang ``` With this change, the above warning is not printed unless `[dreyfus] name` has been set: ``` $ cdb '/_node/_local/_config/dreyfus/name' -X DELETE "[email protected]" $ ./weatherreport -c ../../dev/lib/node1/etc (no warning) $ cdb '/_node/_local/_config/dreyfus/name' -X PUT -d '"[email protected]"' "" $ ./weatherreport -c ../../dev/lib/node1/etc ['[email protected]'] [warning] Local search node at '[email protected]' not responding: pang ``` ## Checklist - [ ] Code is written and works correctly - [ ] Changes are covered by tests - [ ] Any new configurable parameters are documented in `rel/overlay/etc/default.ini` - [ ] Documentation changes were made in the `src/docs` folder - [ ] Documentation changes were backported (separated PR) to affected branches -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
