jcoglan commented on code in PR #4887:
URL: https://github.com/apache/couchdb/pull/4887#discussion_r1410811694
##########
src/weatherreport/src/weatherreport_check_search.erl:
##########
@@ -44,16 +44,24 @@ valid() ->
-spec check(list()) -> [{atom(), term()}].
check(_Opts) ->
- SearchNode = '[email protected]',
- case net_adm:ping(SearchNode) of
- pong ->
- [{info, {clouseau_ok, SearchNode}}];
- Error ->
- % only warning since search is not enabled by default
- [{warning, {clouseau_error, SearchNode, Error}}]
+ SearchNodeStr = config:get("dreyfus", "name"),
+ case SearchNodeStr of
+ undefined ->
+ [{info, clouseau_not_configured}];
+ _ ->
+ SearchNode = list_to_atom(SearchNodeStr),
Review Comment:
I've pushed one more commit that implements this, is it what you had in mind?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
