pgj commented on code in PR #5008:
URL: https://github.com/apache/couchdb/pull/5008#discussion_r1527139130
##########
src/couch_replicator/test/eunit/couch_replicator_scheduler_docs_tests.erl:
##########
@@ -133,9 +133,6 @@ t_scheduler_docs_total_rows({_Ctx, {RepDb, Source,
Target}}) ->
case req(get, SchedulerDocsUrl) of
{200, #{<<"docs">> := [_ | _]} = Decoded} ->
Decoded;
- {_, #{<<"error">> := Error, <<"reason">> := Reason}} ->
Review Comment:
I would not remove this clause. I understand that this PR fixes _one_ of
the possible reasons for having things going wrong. But leaving this here
could help in the future to get the necessary information right away. For
example, when one wants to do something with the respective code and makes an
unintentional mistake. Without this clause it becomes masked and shown as
timeout, which is misleading.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
