nickva commented on code in PR #5008:
URL: https://github.com/apache/couchdb/pull/5008#discussion_r1527564359
##########
src/couch_replicator/test/eunit/couch_replicator_scheduler_docs_tests.erl:
##########
@@ -133,9 +133,6 @@ t_scheduler_docs_total_rows({_Ctx, {RepDb, Source,
Target}}) ->
case req(get, SchedulerDocsUrl) of
{200, #{<<"docs">> := [_ | _]} = Decoded} ->
Decoded;
- {_, #{<<"error">> := Error, <<"reason">> := Reason}} ->
Review Comment:
The typical pattern is to assert only cases we expect and then it should
crash if it gets something else. The code didn't do that before, it accepted
any map and continued to wait.
> Well, with this debug logging of mine we found a bug already.
That was very nice, good stuff!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
