nickva commented on code in PR #5120:
URL: https://github.com/apache/couchdb/pull/5120#discussion_r1667423720


##########
src/couch_quickjs/src/couch_quickjs_scanner_plugin.erl:
##########
@@ -172,8 +172,9 @@ process_ddoc(#st{} = St, DbName, #doc{} = DDoc0) ->
         true ->
             St1 = start_or_reset_procs(St),

Review Comment:
   Because we want to return the updated or reset processes from the catch ... 
expression, but and if we put it inside the try we won't have it available 
there. We expect to always be able to reset/restart the processes on failure.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to