nickva commented on code in PR #5120:
URL: https://github.com/apache/couchdb/pull/5120#discussion_r1667427180
##########
src/couch_quickjs/src/couch_quickjs_scanner_plugin.erl:
##########
@@ -182,11 +183,12 @@ process_ddoc(#st{} = St, DbName, #doc{} = DDoc0) ->
catch
throw:{validate, Error} ->
Meta = #{sid => SId, db => DbName, ddoc => DDocId},
- ?WARN("ddoc validation failed ~p", [Error], Meta),
- St1;
+ validation_warning("ddoc validation failed ~p", Error,
Meta),
+ start_or_reset_procs(St1);
Review Comment:
But you're right we can probably skip resetting them again as every other
block that wants to use them will end up resetting them first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]