nickva commented on code in PR #5132:
URL: https://github.com/apache/couchdb/pull/5132#discussion_r1678731807
##########
src/couch/src/couch_bt_engine_header.erl:
##########
@@ -261,6 +261,7 @@ upgrade_uuid(#db_header{} = Header) ->
end.
upgrade_epochs(#db_header{} = Header) ->
+ Node = init_node_name(),
Review Comment:
I think we call upgrade_epoch for every header open, parse, update params,
etc. This code will call get_arguments which could bottleneck on the init
process. Granted, the init process is not doing anything much anyway, but we
also don't want risk it, it could affect other parts of the system.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
