nickva commented on PR #5132: URL: https://github.com/apache/couchdb/pull/5132#issuecomment-2231958086
Based on discussion in the couchdb dev slack, agree that the shard map creation should probably also use the persistent node name. I tried to gather a bunch more instances. Not all are persistent, some are for active connection so can probably be ignored. The replicator job ownership ones are in between? Some are related to API responses "which node this replication job is running on". Probably not the end of the world if they return `nonode@nohost`. https://github.com/apache/couchdb/blob/f6698ecc68420d7d8307128742b7c637d3ab32ac/src/mem3/src/mem3.erl#L134 https://github.com/apache/couchdb/blob/f6698ecc68420d7d8307128742b7c637d3ab32ac/src/mem3/src/mem3.erl#L147 https://github.com/apache/couchdb/blob/f6698ecc68420d7d8307128742b7c637d3ab32ac/src/mem3/src/mem3.erl#L366 https://github.com/apache/couchdb/blob/f6698ecc68420d7d8307128742b7c637d3ab32ac/src/mem3/src/mem3.erl#L369 https://github.com/apache/couchdb/blob/f6698ecc68420d7d8307128742b7c637d3ab32ac/src/rexi/src/rexi_utils.erl#L28 https://github.com/apache/couchdb/blob/f6698ecc68420d7d8307128742b7c637d3ab32ac/src/mem3/src/mem3_sync.erl#L79 https://github.com/apache/couchdb/blob/f6698ecc68420d7d8307128742b7c637d3ab32ac/src/mem3/src/mem3_sync.erl#L271-L275 https://github.com/apache/couchdb/blob/f6698ecc68420d7d8307128742b7c637d3ab32ac/src/mem3/src/mem3_sync.erl#L305-L309 https://github.com/apache/couchdb/blob/f6698ecc68420d7d8307128742b7c637d3ab32ac/src/couch_log/src/couch_log_writer_stderr.erl#L42 https://github.com/apache/couchdb/blob/f6698ecc68420d7d8307128742b7c637d3ab32ac/src/couch_log/src/couch_log_writer_journald.erl#L40 https://github.com/apache/couchdb/blob/f6698ecc68420d7d8307128742b7c637d3ab32ac/src/dreyfus/src/dreyfus_rpc.erl#L130 https://github.com/apache/couchdb/blob/f6698ecc68420d7d8307128742b7c637d3ab32ac/src/mem3/src/mem3_reshard_dbdoc.erl#L110-L112 https://github.com/apache/couchdb/blob/f6698ecc68420d7d8307128742b7c637d3ab32ac/src/mem3/src/mem3_nodes.erl#L103 https://github.com/apache/couchdb/blob/f6698ecc68420d7d8307128742b7c637d3ab32ac/src/mem3/src/mem3_distribution.erl#L85 https://github.com/apache/couchdb/blob/f6698ecc68420d7d8307128742b7c637d3ab32ac/src/mem3/src/mem3_rpc.erl#L58 https://github.com/apache/couchdb/blob/f6698ecc68420d7d8307128742b7c637d3ab32ac/src/mem3/src/mem3_rpc.erl#L119 https://github.com/apache/couchdb/blob/f6698ecc68420d7d8307128742b7c637d3ab32ac/src/mem3/src/mem3_rep.erl#L64 https://github.com/apache/couchdb/blob/f6698ecc68420d7d8307128742b7c637d3ab32ac/src/mem3/src/mem3_rep.erl#L222 https://github.com/apache/couchdb/blob/f6698ecc68420d7d8307128742b7c637d3ab32ac/src/mem3/src/mem3_shards.erl#L164 https://github.com/apache/couchdb/blob/f6698ecc68420d7d8307128742b7c637d3ab32ac/src/mem3/src/mem3_shards.erl#L406 https://github.com/apache/couchdb/blob/f6698ecc68420d7d8307128742b7c637d3ab32ac/src/nouveau/src/nouveau_util.erl#L41 https://github.com/apache/couchdb/blob/f6698ecc68420d7d8307128742b7c637d3ab32ac/src/chttpd/src/chttpd_node.erl#L39-L41 https://github.com/apache/couchdb/blob/f6698ecc68420d7d8307128742b7c637d3ab32ac/src/chttpd/src/chttpd_misc.erl#L289 https://github.com/apache/couchdb/blob/f6698ecc68420d7d8307128742b7c637d3ab32ac/src/dreyfus/src/dreyfus_index.erl#L85 https://github.com/apache/couchdb/blob/f6698ecc68420d7d8307128742b7c637d3ab32ac/src/couch_replicator/src/couch_replicator_utils.erl#L51 https://github.com/apache/couchdb/blob/f6698ecc68420d7d8307128742b7c637d3ab32ac/src/couch_replicator/src/couch_replicator_scheduler_job.erl#L89 https://github.com/apache/couchdb/blob/f6698ecc68420d7d8307128742b7c637d3ab32ac/src/fabric/src/fabric_util.erl#L123 https://github.com/apache/couchdb/blob/f6698ecc68420d7d8307128742b7c637d3ab32ac/src/couch_replicator/src/couch_replicator_doc_processor.erl#L127 https://github.com/apache/couchdb/blob/f6698ecc68420d7d8307128742b7c637d3ab32ac/src/couch_replicator/src/couch_replicator_doc_processor.erl#L144 https://github.com/apache/couchdb/blob/f6698ecc68420d7d8307128742b7c637d3ab32ac/src/couch_replicator/src/couch_replicator_doc_processor.erl#L596 https://github.com/apache/couchdb/blob/f6698ecc68420d7d8307128742b7c637d3ab32ac/src/couch_replicator/src/couch_replicator_doc_processor.erl#L619 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
