nickva commented on code in PR #5294:
URL: https://github.com/apache/couchdb/pull/5294#discussion_r1795900009


##########
src/nouveau/src/nouveau_fabric_search.erl:
##########
@@ -145,6 +145,9 @@ merge_search_results(A, B, #state{} = State) ->
         ),
         <<"ranges">> => merge_facets(
             maps:get(<<"ranges">>, A, null), maps:get(<<"ranges">>, B, null)
+        ),
+        update_latency => max(

Review Comment:
   It looks a bit odd that this field is an atom while all the others are 
binaries. Should we make them all the same (either all atoms or all binaries).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to