rnewson commented on code in PR #5294:
URL: https://github.com/apache/couchdb/pull/5294#discussion_r1795915624


##########
src/nouveau/src/nouveau_fabric_search.erl:
##########
@@ -145,6 +145,9 @@ merge_search_results(A, B, #state{} = State) ->
         ),
         <<"ranges">> => merge_facets(
             maps:get(<<"ranges">>, A, null), maps:get(<<"ranges">>, B, null)
+        ),
+        update_latency => max(

Review Comment:
   agreed it looks odd, but my reasoning is this: the binaries came from the 
jvm side, as a consequence of being marshalled to/from json. the atoms are 
purely internal (update_latency is calculated on the erlang side). 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to