janl commented on PR #5327: URL: https://github.com/apache/couchdb/pull/5327#issuecomment-2447434804
> Hmm, that's what this PR does? There is already a config change handler, it reconfigures all the native (MFA) bits but didn't do the js engine switch. as I read it, it moves the pull-from-env from `init()` into its own function that is passed into the config change handler. My suggestion would to _just_ move the js engine switch into the config change handler and leave the rest in init. > That's effectively what's happening here. Erlang/OTPs' env is cached gut feeling here, and no strong opinion, but the way we have it before is strictly better at expressing in our code what we mean to happen rather than relying on how OTP works today. Of course, if we did this every time, we reimplemented all of OTP and the is obviously silly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
