nickva commented on PR #5327: URL: https://github.com/apache/couchdb/pull/5327#issuecomment-2447463272
@janl `configure_js_engine/0` already does os:getenv(...) calls, but it does some of them only which leads to a different state if we initialize then just keep calling `configure_js_engine/0`. The way configure engine works is it has to be called afte the main config run. On change the main config has to run again, then calls configure_js_engine(...). > but the way we have it before is strictly better at expressing in our code what we mean to happen I can change I guess, even though I can't think of a way anyone would change the runtime env var settings of the process. Even a regular C process, how would changing its environment variable set work after it already started? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
