chewbranca commented on PR #5602: URL: https://github.com/apache/couchdb/pull/5602#issuecomment-3101278621
Alright I went ahead and reworked the `should_track_init_p` logic in d757adda0 to no longer use the dynamic config lookups and instead use direct function head definitions on the desired metrics. This deletes the `[csrt.init_p]` default.ini section completely and entirely This has the added benefit of removing the fields from the `default.ini` section using the `__` separator, avoiding that issue entirely, although on that front, it'd be worthwhile to formally declare what types of values are acceptable in the keys, as I've been rather hesitant to go wild on that front. This also removed the ugly string conversion in `csrt_util:fabric_conf_key`, and as much emphasis I've made in this PR on avoiding dynamic runtime string conversions for expected entities, I'm very much glad to delete the ugliness of that string conversion! 😅 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
