chewbranca commented on code in PR #5602: URL: https://github.com/apache/couchdb/pull/5602#discussion_r2223679089
########## src/rexi/src/rexi_monitor.erl: ########## @@ -35,6 +35,7 @@ start(Procs) -> %% messages from our mailbox. -spec stop(pid()) -> ok. stop(MonitoringPid) -> + unlink(MonitoringPid), Review Comment: This was an artifact of earlier implementation in https://github.com/apache/couchdb/pull/4812 that dropped the use of selective receives and needed to handle all of the messages, which exposed a number of places where we get unexpected messages in the mailbox. I found the old issues discussing this bug and others, many of which since have been fixed, and I believe this one included. I'll drop this out of the PR. Here's the old issues: * https://github.com/apache/couchdb/issues/5127 * https://github.com/apache/couchdb/issues/5122 * https://github.com/apache/couchdb/issues/4909 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
