nickva commented on code in PR #5666:
URL: https://github.com/apache/couchdb/pull/5666#discussion_r2372751160


##########
src/couch/src/couch_file.erl:
##########
@@ -621,7 +621,7 @@ handle_info({'DOWN', Ref, process, _Pid, _Info}, 
#file{db_monitor = Ref} = File)
         false -> {noreply, File}
     end.
 
-format_status(_Opt, [PDict, #file{} = File]) ->
+format_status([PDict, #file{} = File]) ->

Review Comment:
   > is only triggered when sys:get_status(Pid)
   
   That's one usage, can be used for debugging for instance. However, the 
primary reason we have these in the code-base is to limit the state spill 
during crashes.
   
   Gen-servers, if they exit with a reason other than `normal`, `shutdown` or 
`{shutdown, Reason}` will trigger the logger to dump the state out to the logs. 
And we had tried to limit password dumping and or large state dumping when that 
happens. That's the reason we'd see most of these in the replicator app, for 
instance.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to