nickva commented on code in PR #5666:
URL: https://github.com/apache/couchdb/pull/5666#discussion_r2372866201
##########
src/couch/src/couch_file.erl:
##########
@@ -621,7 +621,7 @@ handle_info({'DOWN', Ref, process, _Pid, _Info},
#file{db_monitor = Ref} = File)
false -> {noreply, File}
end.
-format_status(_Opt, [PDict, #file{} = File]) ->
+format_status([PDict, #file{} = File]) ->
Review Comment:
> The purpose of this instance of format_status is to inject a
InitialFilePath. The value we use for InitialFilePAth is coming from PDict not
from state. This allows us to see the path using sys:get_status(Pid)
But why put it in pdict, and then call `sys:get_status(Pid)` and fetch it
from pdict then the default implementation of `sys:get_status(Pid)` already
returns the state which has the `filepath`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
