nickva opened a new pull request, #5891: URL: https://github.com/apache/couchdb/pull/5891
There are two main improvements: 1) Remove dynamic runtime reloading. That feature is not useful any longer after we stopped doing online relups, and instead became a potential landmine that can lead to metrics unexpectedly failing if stats description files, or disk access to them changes at runtime. The only minor benefit previous behavior had was was for local dev/run development, coupled with online module reloading; but that hardly justifies the complexity and the confusion resulting from stats all of the sudden breaking in production. 2) Strengthen a few asserts during stats loading. Only accept missing stats description from applications, and stop on any other error. We don't want to run with stats missing or unload-able or constantly spewing "unknown metric" error. Potential fix for: #5886 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
