nickva commented on code in PR #5891:
URL: https://github.com/apache/couchdb/pull/5891#discussion_r2829218375
##########
src/couch_stats/src/couch_stats_util.erl:
##########
@@ -51,41 +49,72 @@
% Persistent term keys
-define(STATS_KEY, {?MODULE, stats}).
--define(HIST_TIME_INTERVAL_KEY, {?MODULE, hist_time_interval}).
+
+% Don't waste time looking for stats definition in some built-in and dependency
+% apps. This doesn't have to be an exhaustive list, it's just to avoid doing
+% extra work.
+%
+-define(SKIP_APPS, [
+ public_key,
Review Comment:
> Perhaps, though, it might make sense to add empty files for the
applications that don't have stats so that we expect loading to always work?
This might be a larger change. A good part of applications we have do not
have priv directory with stats cfg (ken, smoosh, ioq, epi, couch_quickjs,
setup, couch_peruser, jwtf, config, custodian, mango, couch_scanner,
weatherreport, ets_lru) so we'd have to add a lot of "ceremony" so to speak.
And then the SKIP_APPS list in stats won't be just a best effort perf boost
(for eunit probably mostly) but it will have to be exhaustive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
