codecov-io commented on issue #1658: [Dubbo-1637] Fix When using hibernate-validator, class 'org.hibernate.validator.internal.metadata.descriptor.ConstraintDescriptorImpl' is wrong with hessian deserialization. URL: https://github.com/apache/incubator-dubbo/pull/1658#issuecomment-384540852 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1658?src=pr&el=h1) Report > Merging [#1658](https://codecov.io/gh/apache/incubator-dubbo/pull/1658?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/a2a7706a07897bc7d0dc79923dc724159766da78?src=pr&el=desc) will **increase** coverage by `0.04%`. > The diff coverage is `61.11%`. [](https://codecov.io/gh/apache/incubator-dubbo/pull/1658?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #1658 +/- ## ============================================ + Coverage 35.42% 35.46% +0.04% - Complexity 3777 3778 +1 ============================================ Files 628 628 Lines 30994 30976 -18 Branches 5456 5448 -8 ============================================ + Hits 10979 10987 +8 + Misses 18124 18094 -30 - Partials 1891 1895 +4 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1658?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...om/alibaba/dubbo/config/spring/AnnotationBean.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1658/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL0Fubm90YXRpb25CZWFuLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [.../main/java/com/alibaba/dubbo/common/Constants.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1658/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL0NvbnN0YW50cy5qYXZh) | `88.88% <ø> (ø)` | `1 <0> (ø)` | :arrow_down: | | [.../exchange/support/header/HeaderExchangeServer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1658/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcmVtb3RpbmcvZXhjaGFuZ2Uvc3VwcG9ydC9oZWFkZXIvSGVhZGVyRXhjaGFuZ2VTZXJ2ZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...rc/main/java/com/alibaba/dubbo/rpc/RpcContext.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1658/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvUnBjQ29udGV4dC5qYXZh) | `30.93% <0%> (+3.89%)` | `27 <0> (ø)` | :arrow_down: | | [...n/java/com/alibaba/dubbo/config/ServiceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1658/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvU2VydmljZUNvbmZpZy5qYXZh) | `39.34% <0%> (-0.19%)` | `42 <0> (ø)` | | | [.../java/com/alibaba/dubbo/config/ProtocolConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1658/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvUHJvdG9jb2xDb25maWcuamF2YQ==) | `34.02% <100%> (+2.27%)` | `39 <0> (ø)` | :arrow_down: | | [...annotation/ServiceAnnotationBeanPostProcessor.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1658/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL2JlYW5zL2ZhY3RvcnkvYW5ub3RhdGlvbi9TZXJ2aWNlQW5ub3RhdGlvbkJlYW5Qb3N0UHJvY2Vzc29yLmphdmE=) | `84.82% <83.33%> (-0.36%)` | `34 <2> (+1)` | | | [...om/alibaba/dubbo/rpc/filter/ActiveLimitFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1658/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvZmlsdGVyL0FjdGl2ZUxpbWl0RmlsdGVyLmphdmE=) | `83.33% <0%> (-5.56%)` | `6% <0%> (ø)` | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1658?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1658?src=pr&el=footer). Last update [a2a7706...f32429a](https://codecov.io/gh/apache/incubator-dubbo/pull/1658?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
