codecov-io commented on issue #1704: issue#1447: NettyHelper in netty extension populated Logger "InternalLogger" in netty. URL: https://github.com/apache/incubator-dubbo/pull/1704#issuecomment-384543574 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1704?src=pr&el=h1) Report > Merging [#1704](https://codecov.io/gh/apache/incubator-dubbo/pull/1704?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/0d002c348ed9307ae60ebe1e0808fb10874c4312?src=pr&el=desc) will **increase** coverage by `0.07%`. > The diff coverage is `23.07%`. [](https://codecov.io/gh/apache/incubator-dubbo/pull/1704?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #1704 +/- ## ============================================ + Coverage 35.37% 35.45% +0.07% - Complexity 3765 3775 +10 ============================================ Files 628 628 Lines 30963 30987 +24 Branches 5438 5449 +11 ============================================ + Hits 10954 10987 +33 + Misses 18109 18106 -3 + Partials 1900 1894 -6 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1704?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...com/alibaba/dubbo/common/logger/LoggerFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1704/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL2xvZ2dlci9Mb2dnZXJGYWN0b3J5LmphdmE=) | `25.49% <0%> (-2.78%)` | `3 <0> (ø)` | | | [...remoting/transport/netty4/logging/NettyHelper.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1704/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcmVtb3RpbmcvdHJhbnNwb3J0L25ldHR5NC9sb2dnaW5nL05ldHR5SGVscGVyLmphdmE=) | `23.58% <100%> (-0.23%)` | `2 <0> (ø)` | | | [...ba/dubbo/common/logger/support/FailsafeLogger.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1704/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL2xvZ2dlci9zdXBwb3J0L0ZhaWxzYWZlTG9nZ2VyLmphdmE=) | `13.63% <28.57%> (+0.22%)` | `4 <1> (-1)` | :arrow_down: | | [...g/context/annotation/DubboConfigConfiguration.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1704/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL2NvbnRleHQvYW5ub3RhdGlvbi9EdWJib0NvbmZpZ0NvbmZpZ3VyYXRpb24uamF2YQ==) | `50% <0%> (-16.67%)` | `0% <0%> (ø)` | | | [...baba/dubbo/remoting/transport/mina/MinaClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1704/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbWluYS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9taW5hL01pbmFDbGllbnQuamF2YQ==) | `57.81% <0%> (-1.57%)` | `8% <0%> (-1%)` | | | [...n/java/com/alibaba/dubbo/common/utils/JVMUtil.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1704/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3V0aWxzL0pWTVV0aWwuamF2YQ==) | `72.22% <0%> (-1.37%)` | `13% <0%> (ø)` | | | [...ba/dubbo/remoting/transport/netty/NettyHelper.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1704/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlIZWxwZXIuamF2YQ==) | `31.25% <0%> (-1.01%)` | `2% <0%> (ø)` | | | [...java/com/alibaba/dubbo/common/utils/PojoUtils.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1704/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3V0aWxzL1Bvam9VdGlscy5qYXZh) | `49.41% <0%> (-0.15%)` | `63% <0%> (ø)` | | | [.../com/alibaba/dubbo/examples/rest/RestProvider.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1704/diff?src=pr&el=tree#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWV4YW1wbGVzL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vZXhhbXBsZXMvcmVzdC9SZXN0UHJvdmlkZXIuamF2YQ==) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: | | ... and [17 more](https://codecov.io/gh/apache/incubator-dubbo/pull/1704/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1704?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1704?src=pr&el=footer). Last update [0d002c3...030ebce](https://codecov.io/gh/apache/incubator-dubbo/pull/1704?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
