codecov-io commented on issue #1707: add an ExpiryCache for CacheFilter URL: https://github.com/apache/incubator-dubbo/pull/1707#issuecomment-384716871 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1707?src=pr&el=h1) Report > Merging [#1707](https://codecov.io/gh/apache/incubator-dubbo/pull/1707?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/00c4201cf8d67db5fe0447ee1e183ad49f51f945?src=pr&el=desc) will **increase** coverage by `6.79%`. > The diff coverage is `52.51%`. [](https://codecov.io/gh/apache/incubator-dubbo/pull/1707?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #1707 +/- ## ============================================ + Coverage 42.66% 49.46% +6.79% + Complexity 4726 4511 -215 ============================================ Files 646 561 -85 Lines 30645 24493 -6152 Branches 5367 4331 -1036 ============================================ - Hits 13076 12116 -960 + Misses 15516 10506 -5010 + Partials 2053 1871 -182 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1707?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...baba/dubbo/cache/support/AbstractCacheFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1707/diff?src=pr&el=tree#diff-ZHViYm8tZmlsdGVyL2R1YmJvLWZpbHRlci1jYWNoZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NhY2hlL3N1cHBvcnQvQWJzdHJhY3RDYWNoZUZhY3RvcnkuamF2YQ==) | `100% <ø> (ø)` | `3 <0> (ø)` | :arrow_down: | | [...va/com/alibaba/dubbo/config/DubboShutdownHook.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1707/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvRHViYm9TaHV0ZG93bkhvb2suamF2YQ==) | `40% <0%> (-3.48%)` | `6 <0> (+1)` | | | [...bbo/cache/support/expiry/ExpiringCacheFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1707/diff?src=pr&el=tree#diff-ZHViYm8tZmlsdGVyL2R1YmJvLWZpbHRlci1jYWNoZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NhY2hlL3N1cHBvcnQvZXhwaXJ5L0V4cGlyaW5nQ2FjaGVGYWN0b3J5LmphdmE=) | `100% <100%> (ø)` | `2 <2> (?)` | | | [...baba/dubbo/cache/support/expiry/ExpiringCache.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1707/diff?src=pr&el=tree#diff-ZHViYm8tZmlsdGVyL2R1YmJvLWZpbHRlci1jYWNoZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NhY2hlL3N1cHBvcnQvZXhwaXJ5L0V4cGlyaW5nQ2FjaGUuamF2YQ==) | `100% <100%> (ø)` | `3 <3> (?)` | | | [...libaba/dubbo/cache/support/expiry/ExpiringMap.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1707/diff?src=pr&el=tree#diff-ZHViYm8tZmlsdGVyL2R1YmJvLWZpbHRlci1jYWNoZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NhY2hlL3N1cHBvcnQvZXhwaXJ5L0V4cGlyaW5nTWFwLmphdmE=) | `47.05% <47.05%> (ø)` | `7 <7> (?)` | | | [.../java/com/alibaba/dubbo/common/utils/LRUCache.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1707/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3V0aWxzL0xSVUNhY2hlLmphdmE=) | `86.2% <83.33%> (+72.41%)` | `11 <5> (+10)` | :arrow_up: | | [...bo/cache/support/threadlocal/ThreadLocalCache.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1707/diff?src=pr&el=tree#diff-ZHViYm8tZmlsdGVyL2R1YmJvLWZpbHRlci1jYWNoZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NhY2hlL3N1cHBvcnQvdGhyZWFkbG9jYWwvVGhyZWFkTG9jYWxDYWNoZS5qYXZh) | `42.85% <0%> (-57.15%)` | `1% <0%> (-2%)` | | | [...aba/dubbo/remoting/transport/mina/MinaChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1707/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbWluYS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9taW5hL01pbmFDaGFubmVsLmphdmE=) | `42.25% <0%> (-11.27%)` | `15% <0%> (-1%)` | | | [...va/com/alibaba/dubbo/cache/filter/CacheFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1707/diff?src=pr&el=tree#diff-ZHViYm8tZmlsdGVyL2R1YmJvLWZpbHRlci1jYWNoZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NhY2hlL2ZpbHRlci9DYWNoZUZpbHRlci5qYXZh) | `73.33% <0%> (-6.67%)` | `4% <0%> (-2%)` | | | [...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1707/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby90ZWxuZXQvSW52b2tlVGVsbmV0SGFuZGxlci5qYXZh) | `51.89% <0%> (-3.8%)` | `11% <0%> (-2%)` | | | ... and [125 more](https://codecov.io/gh/apache/incubator-dubbo/pull/1707/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1707?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1707?src=pr&el=footer). Last update [00c4201...bf593fd](https://codecov.io/gh/apache/incubator-dubbo/pull/1707?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
