codecov-io commented on issue #1707: add an ExpiryCache for CacheFilter URL: https://github.com/apache/incubator-dubbo/pull/1707#issuecomment-384716871 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1707?src=pr&el=h1) Report > Merging [#1707](https://codecov.io/gh/apache/incubator-dubbo/pull/1707?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/00c4201cf8d67db5fe0447ee1e183ad49f51f945?src=pr&el=desc) will **increase** coverage by `6.69%`. > The diff coverage is `32.08%`. [](https://codecov.io/gh/apache/incubator-dubbo/pull/1707?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #1707 +/- ## ============================================ + Coverage 42.66% 49.36% +6.69% + Complexity 4726 4507 -219 ============================================ Files 646 561 -85 Lines 30645 24488 -6157 Branches 5367 4331 -1036 ============================================ - Hits 13076 12088 -988 + Misses 15516 10529 -4987 + Partials 2053 1871 -182 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1707?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...va/com/alibaba/dubbo/config/DubboShutdownHook.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1707/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvRHViYm9TaHV0ZG93bkhvb2suamF2YQ==) | `40% <0%> (-3.48%)` | `6 <0> (+1)` | | | [...o/cache/support/expiring/ExpiringCacheFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1707/diff?src=pr&el=tree#diff-ZHViYm8tZmlsdGVyL2R1YmJvLWZpbHRlci1jYWNoZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NhY2hlL3N1cHBvcnQvZXhwaXJpbmcvRXhwaXJpbmdDYWNoZUZhY3RvcnkuamF2YQ==) | `100% <100%> (ø)` | `2 <2> (?)` | | | [...baba/dubbo/cache/support/expiring/ExpiringMap.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1707/diff?src=pr&el=tree#diff-ZHViYm8tZmlsdGVyL2R1YmJvLWZpbHRlci1jYWNoZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NhY2hlL3N1cHBvcnQvZXhwaXJpbmcvRXhwaXJpbmdNYXAuamF2YQ==) | `25.43% <25.43%> (ø)` | `4 <4> (?)` | | | [...ba/dubbo/cache/support/expiring/ExpiringCache.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1707/diff?src=pr&el=tree#diff-ZHViYm8tZmlsdGVyL2R1YmJvLWZpbHRlci1jYWNoZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NhY2hlL3N1cHBvcnQvZXhwaXJpbmcvRXhwaXJpbmdDYWNoZS5qYXZh) | `70% <70%> (ø)` | `1 <1> (?)` | | | [.../java/com/alibaba/dubbo/common/utils/LRUCache.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1707/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3V0aWxzL0xSVUNhY2hlLmphdmE=) | `86.2% <83.33%> (+72.41%)` | `11 <5> (+10)` | :arrow_up: | | [...bo/cache/support/threadlocal/ThreadLocalCache.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1707/diff?src=pr&el=tree#diff-ZHViYm8tZmlsdGVyL2R1YmJvLWZpbHRlci1jYWNoZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NhY2hlL3N1cHBvcnQvdGhyZWFkbG9jYWwvVGhyZWFkTG9jYWxDYWNoZS5qYXZh) | `42.85% <0%> (-57.15%)` | `1% <0%> (-2%)` | | | [...a/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1707/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDaGFubmVsLmphdmE=) | `57.5% <0%> (-8.75%)` | `19% <0%> (-2%)` | | | [...va/com/alibaba/dubbo/cache/filter/CacheFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1707/diff?src=pr&el=tree#diff-ZHViYm8tZmlsdGVyL2R1YmJvLWZpbHRlci1jYWNoZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NhY2hlL2ZpbHRlci9DYWNoZUZpbHRlci5qYXZh) | `73.33% <0%> (-6.67%)` | `4% <0%> (-2%)` | | | [...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1707/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby90ZWxuZXQvSW52b2tlVGVsbmV0SGFuZGxlci5qYXZh) | `51.89% <0%> (-3.8%)` | `11% <0%> (-2%)` | | | [...ba/dubbo/remoting/transport/netty/NettyClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1707/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDbGllbnQuamF2YQ==) | `72.88% <0%> (-1.26%)` | `12% <0%> (ø)` | | | ... and [123 more](https://codecov.io/gh/apache/incubator-dubbo/pull/1707/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1707?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1707?src=pr&el=footer). Last update [00c4201...33a1d5e](https://codecov.io/gh/apache/incubator-dubbo/pull/1707?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
