codecov-io commented on issue #1944: Put the lock acquisition in front of try URL: https://github.com/apache/incubator-dubbo/pull/1944#issuecomment-397314807 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1944?src=pr&el=h1) Report > Merging [#1944](https://codecov.io/gh/apache/incubator-dubbo/pull/1944?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/928292b1a1938dad96d3965e7f48da5dc0a09373?src=pr&el=desc) will **decrease** coverage by `0.03%`. > The diff coverage is `47.01%`. [](https://codecov.io/gh/apache/incubator-dubbo/pull/1944?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #1944 +/- ## ============================================ - Coverage 49.8% 49.76% -0.04% + Complexity 4576 4574 -2 ============================================ Files 564 564 Lines 24670 24670 Branches 4360 4360 ============================================ - Hits 12286 12278 -8 - Misses 10498 10504 +6 - Partials 1886 1888 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1944?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...va/com/alibaba/dubbo/config/DubboShutdownHook.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1944/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvRHViYm9TaHV0ZG93bkhvb2suamF2YQ==) | `40% <0%> (ø)` | `6 <0> (ø)` | :arrow_down: | | [...o/cache/support/expiring/ExpiringCacheFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1944/diff?src=pr&el=tree#diff-ZHViYm8tZmlsdGVyL2R1YmJvLWZpbHRlci1jYWNoZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NhY2hlL3N1cHBvcnQvZXhwaXJpbmcvRXhwaXJpbmdDYWNoZUZhY3RvcnkuamF2YQ==) | `100% <100%> (ø)` | `2 <2> (ø)` | :arrow_down: | | [...ba/dubbo/cache/support/expiring/ExpiringCache.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1944/diff?src=pr&el=tree#diff-ZHViYm8tZmlsdGVyL2R1YmJvLWZpbHRlci1jYWNoZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NhY2hlL3N1cHBvcnQvZXhwaXJpbmcvRXhwaXJpbmdDYWNoZS5qYXZh) | `100% <100%> (ø)` | `3 <3> (ø)` | :arrow_down: | | [...baba/dubbo/cache/support/expiring/ExpiringMap.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1944/diff?src=pr&el=tree#diff-ZHViYm8tZmlsdGVyL2R1YmJvLWZpbHRlci1jYWNoZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NhY2hlL3N1cHBvcnQvZXhwaXJpbmcvRXhwaXJpbmdNYXAuamF2YQ==) | `40.35% <40.35%> (ø)` | `7 <7> (ø)` | :arrow_down: | | [.../java/com/alibaba/dubbo/common/utils/LRUCache.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1944/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3V0aWxzL0xSVUNhY2hlLmphdmE=) | `86.2% <83.33%> (ø)` | `11 <5> (ø)` | :arrow_down: | | [...a/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1944/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDaGFubmVsLmphdmE=) | `57.5% <0%> (-8.75%)` | `19% <0%> (-2%)` | | | [...om/alibaba/dubbo/rpc/filter/ActiveLimitFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1944/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvZmlsdGVyL0FjdGl2ZUxpbWl0RmlsdGVyLmphdmE=) | `83.33% <0%> (-5.56%)` | `6% <0%> (-1%)` | | | [...ba/dubbo/remoting/transport/netty/NettyServer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1944/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlTZXJ2ZXIuamF2YQ==) | `67.85% <0%> (-3.58%)` | `8% <0%> (-1%)` | | | [...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1944/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby90ZWxuZXQvSW52b2tlVGVsbmV0SGFuZGxlci5qYXZh) | `55.69% <0%> (+3.79%)` | `13% <0%> (+2%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1944?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1944?src=pr&el=footer). Last update [928292b...466c6ac](https://codecov.io/gh/apache/incubator-dubbo/pull/1944?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
