codecov-io commented on issue #1944: Put the lock acquisition in front of try URL: https://github.com/apache/incubator-dubbo/pull/1944#issuecomment-397314807 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1944?src=pr&el=h1) Report > Merging [#1944](https://codecov.io/gh/apache/incubator-dubbo/pull/1944?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/e92a5536465f6a4255c36da3541caa77b0bb735b?src=pr&el=desc) will **increase** coverage by `0.09%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-dubbo/pull/1944?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #1944 +/- ## =========================================== + Coverage 50.31% 50.4% +0.09% - Complexity 4736 4740 +4 =========================================== Files 518 518 Lines 25421 25424 +3 Branches 4546 4560 +14 =========================================== + Hits 12790 12815 +25 + Misses 10670 10654 -16 + Partials 1961 1955 -6 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1944?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...he/dubbo/remoting/transport/netty/NettyClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1944/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eUNsaWVudC5qYXZh) | `72.88% <0%> (-1.26%)` | `12% <0%> (ø)` | | | [...e/dubbo/remoting/transport/netty4/NettyClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1944/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5Q2xpZW50LmphdmE=) | `63.33% <0%> (-1.08%)` | `11% <0%> (ø)` | | | [...ache/dubbo/remoting/transport/mina/MinaClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1944/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbWluYS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcmVtb3RpbmcvdHJhbnNwb3J0L21pbmEvTWluYUNsaWVudC5qYXZh) | `58.46% <0%> (-0.92%)` | `9% <0%> (ø)` | | | [.../java/org/apache/dubbo/config/ReferenceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1944/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9SZWZlcmVuY2VDb25maWcuamF2YQ==) | `47.68% <0%> (+0.71%)` | `38% <0%> (ø)` | :arrow_down: | | [.../dubbo/rpc/protocol/dubbo/DecodeableRpcResult.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1944/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0RlY29kZWFibGVScGNSZXN1bHQuamF2YQ==) | `45.31% <0%> (+1.56%)` | `8% <0%> (ø)` | :arrow_down: | | [...he/dubbo/registry/multicast/MulticastRegistry.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1944/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktbXVsdGljYXN0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9tdWx0aWNhc3QvTXVsdGljYXN0UmVnaXN0cnkuamF2YQ==) | `57.74% <0%> (+1.67%)` | `41% <0%> (+3%)` | :arrow_up: | | [...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1944/diff?src=pr&el=tree#diff-ZHViYm8tbW9uaXRvci9kdWJiby1tb25pdG9yLWRlZmF1bHQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL21vbml0b3IvZHViYm8vRHViYm9Nb25pdG9yLmphdmE=) | `89.71% <0%> (+1.86%)` | `15% <0%> (ø)` | :arrow_down: | | [...in/java/org/apache/dubbo/common/utils/IOUtils.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1944/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvSU9VdGlscy5qYXZh) | `86.95% <0%> (+2.17%)` | `16% <0%> (+1%)` | :arrow_up: | | [...va/org/apache/dubbo/remoting/exchange/Request.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1944/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9SZXF1ZXN0LmphdmE=) | `85.71% <0%> (+2.38%)` | `20% <0%> (ø)` | :arrow_down: | | [...bo/rpc/protocol/dubbo/telnet/LogTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1944/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL3RlbG5ldC9Mb2dUZWxuZXRIYW5kbGVyLmphdmE=) | `71.42% <0%> (+2.85%)` | `3% <0%> (ø)` | :arrow_down: | | ... and [3 more](https://codecov.io/gh/apache/incubator-dubbo/pull/1944/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1944?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1944?src=pr&el=footer). Last update [e92a553...d84ffde](https://codecov.io/gh/apache/incubator-dubbo/pull/1944?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
