Gucvii commented on code in PR #2868:
URL: https://github.com/apache/dubbo-go/pull/2868#discussion_r2084651632
##########
metadata/info/metadata_info.go:
##########
@@ -212,6 +212,7 @@ type ServiceInfo struct {
Port int `json:"port,omitempty" hessian:"port"`
Path string `json:"path,omitempty" hessian:"path"`
Params map[string]string `json:"params,omitempty" hessian:"params"`
+ Weight int64 `json:"weight,omitempty" hessian:"weight"`
Review Comment:
说实话,这个weight层级真的很让人头疼,按照之前的命名看是method层级的,但是这实现起来显然太复杂,我考虑Service层级是因为dubbo
java的注解就是加载service上面,不过,我也希望目前先分离出来,因为目前的实现是server层级的(单个server内所有service权重相等(dubbogo的很多代码里可以看出来,当初设计的时候单个server是有多个serviceinfo的)),你能推荐一个更好的传参方式吗
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]