Gucvii commented on code in PR #2868: URL: https://github.com/apache/dubbo-go/pull/2868#discussion_r2084659142
########## common/constant/default.go: ########## @@ -32,21 +32,21 @@ const ( ) const ( - DefaultWeight = 100 - DefaultWarmup = 10 * 60 // in java here is 10*60*1000 because of System.currentTimeMillis() is measured in milliseconds & in go time.Unix() is second - DefaultLoadBalance = "random" - DefaultRetries = "2" - DefaultRetriesInt = 2 - DefaultProtocol = "dubbo" - DefaultRegTimeout = "5s" - DefaultRegTTL = "15m" - DefaultCluster = "failover" - DefaultFailbackTimes = "3" - DefaultFailbackTimesInt = 3 - DefaultFailbackTasks = 100 - DefaultRestClient = "resty" - DefaultRestServer = "go-restful" - DefaultPort = 20000 + DefaultWeight int64 = 100 Review Comment: ok 那我把全局的weight int64都改成int?但是这种动态位数的放在权重这块真的好吗，虽然现在32位主机应该不多了，要不这个征求下雨哥意见，毕竟nacos的权重的float64的，也许确实大有大的道理 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
