zrlw commented on code in PR #15518:
URL: https://github.com/apache/dubbo/pull/15518#discussion_r2182412281
##########
dubbo-remoting/dubbo-remoting-http3/src/main/java/org/apache/dubbo/remoting/http3/netty4/NettyHttp3FrameCodec.java:
##########
@@ -95,7 +96,11 @@ public void write(ChannelHandlerContext ctx, Object msg,
ChannelPromise promise)
new
DefaultHttp3HeadersFrame(((NettyHttpHeaders<Http3Headers>)
headers.headers()).getHeaders()),
promise);
if (headers.isEndStream()) {
- ctx.close();
+ if (promise.isDone()) {
Review Comment:
As for me, the client might close the context immediately after it
determined that the FIN packet has been received,
the client should wait sending operation completion before doing stream
close operation if it just sends ONE-WAY messages and does not get any stream
closed notifications from the server, i might miss these codes because i am not
familiar with h3 client processing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
