Stellar1999 commented on code in PR #15518:
URL: https://github.com/apache/dubbo/pull/15518#discussion_r2184192532
##########
dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/TriHttp2RemoteFlowController.java:
##########
@@ -778,11 +778,7 @@ private void
checkConnectionThenStreamWritabilityChanged(FlowState state) throws
} else if (isWritable(state) != state.markedWritability()) {
notifyWritabilityChanged(state);
} else if (isOverFlowControl()) {
- throw streamError(
- state.stream().id(),
- FLOW_CONTROL_ERROR,
- "TotalPendingBytes size overflow for stream: %d",
- state.stream().id());
+ logger.warn("TotalPendingBytes size overflow for stream: " +
state.stream().id());
Review Comment:
Maybe log error will be better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
