1kasa commented on code in PR #3018:
URL: https://github.com/apache/dubbo-go/pull/3018#discussion_r2335137004
##########
common/rpc_service.go:
##########
@@ -373,8 +373,10 @@ func suiteMethod(method reflect.Method) *MethodType {
// Reference is used to define service reference, and method with
prefix 'XXX' is generated by triple pb tool.
// SetGRPCServer is used for pb reflection.
+ // Health helper methods are not RPCs and should be ignored.
// They should not to be checked.
- if mname == "Reference" || mname == "SetGRPCServer" ||
strings.HasPrefix(mname, "XXX") {
+ if mname == "Reference" || mname == "SetGRPCServer" ||
strings.HasPrefix(mname, "XXX") ||
+ mname == "Resume" || mname == "Shutdown" || mname ==
"SetServingStatus" {
Review Comment:
Besides the several methods of health.HealthTripleServer that require
special handling, are there any other similar methods? If not, I think I can
write something more accurate like this: (method.Type.In(0).String() ==
"*health.HealthTripleServer") &&
(mname == "Restore" || mname == "SetServingStatus" || mname == "Shutdown")
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
