No-SilverBullet commented on code in PR #3018:
URL: https://github.com/apache/dubbo-go/pull/3018#discussion_r2331908428
##########
protocol/triple/health/healthServer.go:
##########
@@ -117,15 +117,16 @@ func (srv *HealthTripleServer) Watch(ctx context.Context,
request *triple_health
// SetServingStatus is called when need to reset the serving status of a
service
// or insert a new service entry into the statusMap.
-func (srv *HealthTripleServer) SetServingStatus(service string, servingStatus
triple_health.HealthCheckResponse_ServingStatus) {
+func (srv *HealthTripleServer) SetServingStatus(service string, servingStatus
triple_health.HealthCheckResponse_ServingStatus) error {
Review Comment:
> I thought this might be more standard. If this change isn't appropriate, I
can revert it and remove the 'error'.
If the error is always empty, I don't think there is any need to add a
return. unless you are implementing an interface
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
