RainYuY commented on PR #92: URL: https://github.com/apache/dubbo-hessian-lite/pull/92#issuecomment-3319492465
Thank you for your work — it looks good and productive. I will need some time to review these changes in detail, but I would like to point out one thing first: this code requires a complete set of unit tests to ensure that the serialization of all these classes works correctly both before and after the modification. Without such tests, this PR cannot be merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
