RainYuY commented on code in PR #15639:
URL: https://github.com/apache/dubbo/pull/15639#discussion_r2384428723
##########
dubbo-common/src/main/java/org/apache/dubbo/common/utils/UrlUtils.java:
##########
@@ -522,6 +523,10 @@ public static boolean isRegistry(URL url) {
|| (url.getProtocol() != null &&
url.getProtocol().endsWith("-registry-protocol"));
}
+ public static boolean isCheck(URL url) {
+ return url.getParameter(CHECK_KEY, true) && url.getPort() != 0;
Review Comment:
why check url.getPort() != 0?
##########
dubbo-configcenter/dubbo-configcenter-zookeeper/src/main/java/org/apache/dubbo/configcenter/support/zookeeper/ZookeeperDynamicConfiguration.java:
##########
@@ -68,23 +67,6 @@ public class ZookeeperDynamicConfiguration extends
TreePathDynamicConfiguration
new AbortPolicyWithReport(threadName, url));
zkClient = zookeeperClientManager.connect(url);
- boolean isConnected = zkClient.isConnected();
Review Comment:
Will this deletion possibly affect prepareEnvironment?
##########
dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ServiceConfig.java:
##########
@@ -400,11 +398,7 @@ protected void exported() {
exportedURLs.forEach(url -> {
if (url.getParameter(SERVICE_NAME_MAPPING_KEY, false)) {
ServiceNameMapping serviceNameMapping =
ServiceNameMapping.getDefaultExtension(getScopeModel());
- ScheduledExecutorService scheduledExecutor = getScopeModel()
- .getBeanFactory()
- .getBean(FrameworkExecutorRepository.class)
- .getSharedScheduledExecutor();
- mapServiceName(url, serviceNameMapping, scheduledExecutor);
+ mapServiceName(url, serviceNameMapping);
Review Comment:
why remove scheduledExecutor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
