fantiq commented on code in PR #15639:
URL: https://github.com/apache/dubbo/pull/15639#discussion_r2387344200
##########
dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ServiceConfig.java:
##########
@@ -400,11 +398,7 @@ protected void exported() {
exportedURLs.forEach(url -> {
if (url.getParameter(SERVICE_NAME_MAPPING_KEY, false)) {
ServiceNameMapping serviceNameMapping =
ServiceNameMapping.getDefaultExtension(getScopeModel());
- ScheduledExecutorService scheduledExecutor = getScopeModel()
- .getBeanFactory()
- .getBean(FrameworkExecutorRepository.class)
- .getSharedScheduledExecutor();
- mapServiceName(url, serviceNameMapping, scheduledExecutor);
+ mapServiceName(url, serviceNameMapping);
Review Comment:
It was move to a new class
https://github.com/apache/dubbo/blob/eb728417846025108aa61fb7ae777018b9ea96af/dubbo-metadata/dubbo-metadata-api/src/main/java/org/apache/dubbo/metadata/report/MetadataReportRetryTask.java
It will only retry metadata-report client that fail to report.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]