nanjiek commented on code in PR #3054:
URL: https://github.com/apache/dubbo-go/pull/3054#discussion_r2441842070
##########
registry/protocol/protocol.go:
##########
@@ -185,12 +186,33 @@ func (proto *registryProtocol) Refer(url *common.URL)
base.Invoker {
// Export provider service to registry center
func (proto *registryProtocol) Export(originInvoker base.Invoker)
base.Exporter {
- proto.once.Do(func() {
- proto.initConfigurationListeners()
- })
registryUrl := getRegistryUrl(originInvoker)
providerUrl := getProviderUrl(originInvoker)
+ if _, ok := registryUrl.GetAttribute(constant.ShutdownConfigPrefix);
!ok {
+ // Only set default global config when config package doesn't
have one
+ if config.GetShutDown() == nil {
Review Comment:
The logic of advice is wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
