Alanxtl commented on code in PR #3054:
URL: https://github.com/apache/dubbo-go/pull/3054#discussion_r2442784775
##########
registry/protocol/protocol.go:
##########
@@ -518,14 +578,29 @@ type providerConfigurationListener struct {
overrideListeners *sync.Map
}
-func newProviderConfigurationListener(overrideListeners *sync.Map)
*providerConfigurationListener {
+func newProviderConfigurationListener(overrideListeners *sync.Map, url
*common.URL) *providerConfigurationListener {
listener := &providerConfigurationListener{}
listener.overrideListeners = overrideListeners
- listener.InitWith(
-
config.GetRootConfig().Application.Name+constant.ConfiguratorSuffix,
- listener,
- extension.GetDefaultConfiguratorFunc(),
- )
+
+ // Fallback to config package (old API)
Review Comment:
```suggestion
//TODO: Temporary compatibility with old APIs, can be removed later
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
