Alanxtl commented on code in PR #3029:
URL: https://github.com/apache/dubbo-go/pull/3029#discussion_r2447967185
##########
cluster/router/tag/router.go:
##########
@@ -116,9 +116,9 @@ func (p *PriorityRouter) Process(event
*config_center.ConfigChangeEvent) {
logger.Infof("[tag router]Parse tag router config
success,routerConfig=%+v", routerConfig)
}
-func parseRoute(routeContent string) (*config.RouterConfig, error) {
+func parseRoute(routeContent string) (*router.RouterConfig, error) {
Review Comment:
need to make sure upstream won't pass in a `*config.RouterConfig`, if
upstream pass in a `*config.RouterConfig` programme will panic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
