Alanxtl commented on code in PR #3198:
URL: https://github.com/apache/dubbo-go/pull/3198#discussion_r2777658665
##########
remoting/getty/getty_client_test.go:
##########
@@ -83,10 +82,7 @@ func setAttachment(invocation *invocation.RPCInvocation,
attachments map[string]
}
func getClient(url *common.URL) *Client {
- client := NewClient(Options{
- // todo fix timeout
- ConnectTimeout: 3 * time.Second, //
config.GetConsumerConfig().ConnectTimeout,
- })
Review Comment:
does this timeout problem solved?
##########
remoting/nacos/builder_test.go:
##########
@@ -16,195 +16,3 @@
*/
package nacos
Review Comment:
Investigate the specific purpose of this test file and add corresponding
tests; do not simply delete it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
