Alanxtl commented on code in PR #3198:
URL: https://github.com/apache/dubbo-go/pull/3198#discussion_r2779167096
##########
remoting/getty/getty_client_test.go:
##########
@@ -83,10 +82,7 @@ func setAttachment(invocation *invocation.RPCInvocation,
attachments map[string]
}
func getClient(url *common.URL) *Client {
- client := NewClient(Options{
- // todo fix timeout
- ConnectTimeout: 3 * time.Second, //
config.GetConsumerConfig().ConnectTimeout,
- })
Review Comment:
把这个timeout的修复单独拆出去作为一个pr，这个pr就只解决config的问题
##########
remoting/getty/getty_client_test.go:
##########
@@ -38,13 +38,15 @@ import (
import (
"dubbo.apache.org/dubbo-go/v3/common"
"dubbo.apache.org/dubbo-go/v3/common/constant"
- "dubbo.apache.org/dubbo-go/v3/config"
"dubbo.apache.org/dubbo-go/v3/global"
"dubbo.apache.org/dubbo-go/v3/protocol/base"
"dubbo.apache.org/dubbo-go/v3/protocol/invocation"
"dubbo.apache.org/dubbo-go/v3/protocol/result"
"dubbo.apache.org/dubbo-go/v3/proxy/proxy_factory"
"dubbo.apache.org/dubbo-go/v3/remoting"
+ perrors "github.com/pkg/errors"
+ "github.com/stretchr/testify/assert"
+ "github.com/stretchr/testify/require"
Review Comment:
为啥这里加了这几个imports
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
