Copilot commented on code in PR #3212:
URL: https://github.com/apache/dubbo-go/pull/3212#discussion_r2798493413
##########
protocol/dubbo3/internal/client.go:
##########
@@ -15,15 +15,4 @@
* limitations under the License.
*/
-package internal
-
-import (
- "dubbo.apache.org/dubbo-go/v3/config"
-)
-
-// TODO: After the config is removed, remove the test
-func init() {
- // for pb client
-
config.SetConsumerServiceByInterfaceName("org.apache.dubbo.DubboGreeterImpl",
&GreeterClientImpl{})
- config.SetConsumerService(&GreeterClientImpl{})
-}
+package internal
Review Comment:
`client.go` is now effectively an empty file (only the package declaration
remains) after removing the config registration init. Since the package already
contains other `.go` files, this file no longer serves a purpose and can be
deleted to avoid confusion and reduce maintenance overhead.
```suggestion
package internal
// _clientFileSentinel exists only to ensure this file is non-empty and
// to keep the package structure clear for potential future client-related
code.
type _clientFileSentinel struct{}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
