Snow-kal commented on code in PR #3212:
URL: https://github.com/apache/dubbo-go/pull/3212#discussion_r2798709590
##########
protocol/dubbo3/internal/client.go:
##########
@@ -15,15 +15,4 @@
* limitations under the License.
*/
-package internal
-
-import (
- "dubbo.apache.org/dubbo-go/v3/config"
-)
-
-// TODO: After the config is removed, remove the test
-func init() {
- // for pb client
-
config.SetConsumerServiceByInterfaceName("org.apache.dubbo.DubboGreeterImpl",
&GreeterClientImpl{})
- config.SetConsumerService(&GreeterClientImpl{})
-}
+package internal
Review Comment:
因为 golangci-lint 工具检测到 protocol/dubbo3/internal/client.go 文件中有一个未使用的类型
_clientFileSentinel 所以之后删除了
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
