mochengqian opened a new issue, #938: URL: https://github.com/apache/dubbo-go-pixiu/issues/938
Today `EndpointChecker.HandleFailure(timeout bool)` discards its argument via `_ = timeout`. The boolean is preserved for v1.x backward compatibility because external Checker implementations may still pass it. `HandleTimeout` similarly routes to `HandleFailure(true)`. This is dead surface but cannot be removed inside #932 because the methods are exported. Proposed: - In v2.x, drop the `timeout bool` parameter from `HandleFailure`, then inline `HandleTimeout` into its single caller, the `<-c.timeout` branch in `EndpointChecker.Start`. - Coordinate with any external Checker implementations during the major release migration window. Reference: PR #932 reviewer noted the discarded parameter as API smell; #932 documents it as deprecated ahead of removal. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
