mochengqian commented on issue #938:
URL: https://github.com/apache/dubbo-go-pixiu/issues/938#issuecomment-4642992419
Confirming the current state and the right disposition for this one.
The deprecation scaffolding is already fully in place on `develop`, so
nothing needs to (or should) change before the next major:
- `EndpointChecker.HandleFailure(timeout bool)` already discards the arg (`_
= timeout`) and carries a `Deprecated:` godoc telling new code to pass `false`
and noting the next-major collapse to `HandleFailure()`.
- `HandleTimeout()` is already `Deprecated:` and is a thin wrapper routing
to `HandleFailure(true)`.
- Both in-tree failure branches in `Start()` and the timeout branch already
funnel into the same unhealthy counter, so the boolean is genuinely
behavior-neutral today.
So this is purely an API-surface cleanup gated on a major release, exactly
as the issue scopes it. Doing it now would be a breaking change to an exported
method for external `Checker` implementations, with zero behavior benefit — not
worth it in a v1.x line.
**Proposed disposition:** keep this open as a tracking issue for the next
major. When that lands, the mechanical change is:
1. `Start()`: both branches call `HandleFailure()`.
2. Collapse the signature to `HandleFailure()`.
3. Remove `HandleTimeout()` (true next-major cleanup — no reason to keep the
wrapper once the arg is gone).
4. Update `healthcheck_test.go` (the `HandleFailure(false/true)` calls and
`TestHandleTimeoutRoutesThroughHandleFailure`).
5. `git grep 'HandleFailure(\|HandleTimeout('` to catch any new call sites
added in the meantime.
I'd suggest a `next-major` / `breaking-change` label so it doesn't get
picked up as a `contribute welcome` task by mistake — the scaffolding is
intentional and removing it early breaks the deprecation contract. Happy to own
the change when the major window opens.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
