mochengqian opened a new issue, #939: URL: https://github.com/apache/dubbo-go-pixiu/issues/939
The LLM proxy filter currently keeps cooldown state in a package-level `sharedCooldownStore`, initialized by `newCooldownStore()` at package load. `RequestExecutor.cooldownStore()` has a multi-level fallback path, but production construction should make the store explicit instead of falling back through executor, filter, factory, and global state. Two correlated issues: - Package global state makes test isolation awkward and prevents the filter from observing per-cluster or per-manager cooldown policy. - The fallback resolver path is over-engineered relative to the production construction path. Proposed: - Make `ClusterManager` own the cooldown store, one per process is fine. - Inject through `FilterFactory` at construction time; make `RequestExecutor.cooldowns` always set. - Delete `sharedCooldownStore` and the fallback resolver helpers. Reference: PR #932 tracks this as a follow-up after moving cooldown state out of endpoint metadata. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
