Skylm808 commented on code in PR #948:
URL: https://github.com/apache/dubbo-go-pixiu/pull/948#discussion_r3342085970
##########
pkg/filter/http/apiconfig/api_config.go:
##########
@@ -74,8 +69,8 @@ func (factory *FilterFactory) Config() any {
func (factory *FilterFactory) Apply() error {
factory.apiService = api.NewLocalMemoryAPIDiscoveryService()
- if factory.cfg.Dynamic && (factory.cfg.EnableOpenAPIValidation ||
factory.cfg.OpenAPIPath != "") {
- return errors.New("dynamic api config does not support openapi
validation")
+ if factory.cfg.OpenAPIPath != "" || factory.cfg.EnableOpenAPIValidation
{
Review Comment:
已处理。现在 apiconfig 会在 YAML 解析时记录 openapi_path 和 enable_openapi_validation 这两个旧
key 是否出现过，所以即使配置成 openapi_path: "" 或 enable_openapi_validation: false，也会 fail
fast 提示迁移到 dgp.filter.http.openapi。对应场景的回归测试也补了。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
