Skylm808 commented on code in PR #948:
URL: https://github.com/apache/dubbo-go-pixiu/pull/948#discussion_r3342136729
##########
pkg/filter/http/apiconfig/config.go:
##########
@@ -23,10 +23,8 @@ import (
// ApiConfigConfig the config for api_config filter
type ApiConfigConfig struct {
- APIMetaConfig *model.APIMetaConfig `yaml:"api_meta_config"
json:"api_meta_config,omitempty"`
- Path string `yaml:"path"
json:"path,omitempty"`
- Dynamic bool `yaml:"dynamic"
json:"dynamic,omitempty"`
- DynamicAdapter string `yaml:"dynamic_adapter"
json:"dynamic_adapter,omitempty"`
- OpenAPIPath string `yaml:"openapi_path"
json:"openapi_path,omitempty"`
- EnableOpenAPIValidation bool
`yaml:"enable_openapi_validation" json:"enable_openapi_validation,omitempty"`
+ APIMetaConfig *model.APIMetaConfig `yaml:"api_meta_config"
json:"api_meta_config,omitempty"`
+ Path string `yaml:"path" json:"path,omitempty"`
+ Dynamic bool `yaml:"dynamic"
json:"dynamic,omitempty"`
+ DynamicAdapter string `yaml:"dynamic_adapter"
json:"dynamic_adapter,omitempty"`
}
Review Comment:
已处理。现在保留了 apiconfig 里的 openapi_path 和 enable_openapi_validation 旧字段，并在
Apply() 阶段 fail fast，提示用户迁移到独立的 dgp.filter.http.openapi filter。后续也补充了 key
presence 检测，所以即使 openapi_path: "" 或 enable_openapi_validation: false
也会触发迁移提示。已补回归测试。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
