yin-bo-Final opened a new pull request, #16309: URL: https://github.com/apache/dubbo/pull/16309
Fixes #16308 ## What is the purpose of the change? This PR fixes `NetUtils.matchIpExpression(String, String)` so it can correctly parse normal IPv4 `host:port` addresses, such as `192.168.1.63:90`. Previously, the method only split the address when it ended with `:`, so a normal IPv4 address with port was treated as the full host string and could fail with `UnknownHostException`. The fix parses the address only when it contains exactly one colon, avoiding impact on IPv6 addresses. ## Checklist - [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project. - [x] Make sure gitHub actions can pass. [Why the workflow is failing and how to fix it?](../CONTRIBUTING.md) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
